Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSS reader never stops #171

Merged
merged 1 commit into from
Aug 10, 2024
Merged

RSS reader never stops #171

merged 1 commit into from
Aug 10, 2024

Conversation

w3stling
Copy link
Owner

@w3stling w3stling commented Aug 10, 2024 •
edited
Loading

The PR fixes issue #170 causing the program never to stop.

Example:

public static void main(String[] args) throws IOException {
    RssReader rssReader = new RssReader();
    List<Item> items = rssReader.read(URL).toList();
}

Fixed by using daemon threads in the executor service

@w3stling w3stling added the bug Something isn't working label Aug 10, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Test Results

  9 files    9 suites   31s ⏱️
149 tests 147 ✅ 2 💤 0 ❌
157 runs  155 ✅ 2 💤 0 ❌

Results for commit 0621893.

@w3stling w3stling merged commit 5a37e22 into master Aug 10, 2024
5 checks passed
@w3stling w3stling deleted the bug-fix-rssreader-never-stops branch August 10, 2024 14:30
@w3stling w3stling mentioned this pull request Aug 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@w3stling